Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing account module #1743

Merged
merged 9 commits into from
Oct 15, 2023
Merged

Billing account module #1743

merged 9 commits into from
Oct 15, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Oct 10, 2023

Still missing

  • tests and examples
  • README

FAST IAM binding resources will be converted to the new module only if it improves legibility.

Fixes #1721

@ludoo ludoo marked this pull request as ready for review October 14, 2023 12:39
@ludoo ludoo requested a review from juliocc October 14, 2023 12:39
ludoo added 2 commits October 14, 2023 15:05
…latform/cloud-foundation-fabric into ludo/billing-account-module
@ludoo ludoo enabled auto-merge (squash) October 14, 2023 16:06
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. Left a few minor comments here and there.

modules/billing-account/README.md Show resolved Hide resolved
modules/billing-account/budgets.tf Outdated Show resolved Hide resolved
modules/billing-account/budgets.tf Outdated Show resolved Hide resolved
modules/billing-account/variables.tf Outdated Show resolved Hide resolved
modules/billing-account/variables.tf Show resolved Hide resolved
fast/stages/0-bootstrap/billing.tf Show resolved Hide resolved
@ludoo ludoo merged commit 252127b into master Oct 15, 2023
9 checks passed
@ludoo ludoo deleted the ludo/billing-account-module branch October 15, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New billing account module with budgets and sinks
2 participants